League-of-Foundry-Developers/foundry-token-hotbar

Hotbars sometimes disappear

Closed this issue · 3 comments

janssen-io commented

I encountered this bug when setting macros on several linked tokens.
Might be related to refreshing/updates not coming through to the server? But a refresh is not always necessary to reproduce the problem.

Possibly related: save is called twice when clicking on a token with a token hotbar. Sometimes even a third time with only part of the token hotbar (less entities). It might be that save is triggered before the loading is done.

Environment:

  • Foundry 0.6.2
  • Token Hotbar 2.0.2
  • Linux hosted, Firefox 77.0.1 client

Reproduction:

  1. Add two tokens on the canvas (in my case linked to actors, but I believe it's not related)
  2. Add distinct macros on each token hotbar.
  3. Switch between them a few times and observe the following in the console (enable console.debug)

image

Notice how, after switching to Bzyx... save is called two times with the entire token hotbar flag and a third time with only a subset of it (without 6thn... macros).

janssen-io commented

Cannot reproduce in Foundry VTT Windows client, which leads me to think it's a race condition.

janssen-io commented

Fixed for v2.1.0

janssen-io commented

Fix does not seem sufficient. Trying to find new reproduction steps...