League-of-Foundry-Developers/scene-packer

[BUG] Conflict with Warhammer Module

Closed this issue · 2 comments

Craftzero commented

Describe the bug
Receive an error upon entering Warhammer via the Libwrapper module. In practice, I have seen some oddities tied to Baileywiki modules that may have Scene Packer requirements.

Versions (please complete the following information):

  • FoundryVTT Core: Version 9 - Build 238
  • System: Warhammer v5.0.3
  • Scene Packer Version: v2.3.25

To Reproduce
Steps to reproduce the behavior:

  1. Install Warhammer/Lib Wrapper/Scene Packer
  2. Start Up Warhammer

Expected behavior
I would expect no error upon starting Warhammer.

Screenshots
Capture2

Capture1

Additional context
Add any other context about the problem here.

sneat commented

Hi @Craftzero, as discussed on Discord, this technically isn't an error, it's a warning. It's annoying getting warnings like this in the console, but it shouldn't be causing any problems for you for the following reasons:

  1. The potential conflict only exists when exporting Journals, Scenes or RollTables to a compendium, which I assume you aren't doing very often (if at all).
  2. The way that Scene Packer has wrapped that portion, it should be calling the Warhammer version of the toCompendium methods, and then adding its additional data. So there shouldn't be an issue.

I'll leave this issue open for now though while we discuss more on Discord just in case there's something that I can adjust in Scene Packer to make the interaction better overall.

sneat commented

Other issue mentioned on Discord was resolved within the Warhammer system.