Add XinFin network (XDC)
cseguret-ledger opened this issue · 6 comments
Description
- Symbol: XDC
- ChainId: 50
- Website: https://xinfin.org/
- Block-Explorer: https://explorer.xinfin.network/
- slip-0044 type: 550
Additional comments
@cseguret-ledger thank you for cleaning up. How does this work? Does a new PR need to be created? This PR was sitting around for 2 years now. Sill not merged. And now closed.. 😢
@cseguret-ledger thank you for cleaning up. How does this work? Does a new PR need to be created? This PR was sitting around for 2 years now. Sill not merged. And now closed.. cry
I cleaned up the repo and the old PR a bit. That's why I turned them into an issue because there will be some changes in the code
Ok.
So it appears a new PR shall be created.
This is Issue/Chain is not part of the Chain/Network Project.
#245 suggests that only PRs of Ledger-Employees and in the Chain/Network Project will be accepted?
Hello @Draghtnod @cseguret-ledger , Kindly let us know when we will be able to use Ledger for XDC.Network
Hi @AnilChinchawale. I don't know either. I'm not affiliated with Ledger, just trying to help. People start creating PRs for other chains again. They look exactly the same like the ones that got closed. See #274, #270, #265, #245 and so on. None of them got merged yet.
There is a new Chain PR Template here: https://github.com/LedgerHQ/app-ethereum/blob/d749f3dc325ed37653e7c5149132bca2f6c9146d/.github/ISSUE_TEMPLATE/network_request.md
So it looks like a new PR is the correct way.
Also check here: 4c6ecf8
The changes in the Makefile have been moved into separate files.
Maybe there is a document with some guidelines or a checklist how to get a new chain merged, who to ask for a merge and to which address the bribe money goes. I have not found it yet.
Nonetheless, you got my respect. Trying to merge this for 2 years without throwing your desk out the window is an achievement not everyone can endure.
Hello,
New PR has been created with new guidelines #293, @cseguret-ledger Can you share feedback.
Thank you @Draghtnod for your kind words.