Need to whitelist an Arbitrum contract
Closed this issue · 6 comments
I need to whitelist an Arbitrum contract. Looking at the root of this repo I don't see arbitrum folder created, but then I read this post about Arbitrum support on Ledger.
In order to whitelist an Arbitrum contract - should it be added in the ethereum directory?
what are you trying to achieve with this whitelisting @ntourne ?
@adrienlacombe-ledger: I'd like to allow Ledger users to sign EIP-712 messages on OZ governor and ERC20 token contracts. In particular, castVoteBySig and delegateBySig.
Extra question: I need to whitelist a couple of OZ governor and ERC20 contracts from different DAOs. Is it better to make one PR per DAO? or just a unique PR with all these changes?
For ERC-20 please go there https://developers.ledger.com/docs/token/erc20-bep20/
For EIP-712, yes, you can create an arbitrum folder np.
Thank you!
Thank you, @adrienlacombe-ledger! Going to check out.
I need to whitelist a couple of OZ governor and ERC20 contracts from different DAOs. Is it better to make one PR per DAO? or just a unique PR with all these changes?
Following up on @ntourne's question:
Tally is a dapp for interacting with DAO smart contracts. At Tally, we want to support EIP-712 signatures on token and Governor contracts for Uniswap, ENS, Gitcoin, and many more. Should we put those contracts into a single directory, ethereum/tally/ or into separate ones, like ethereum/uniswap/ and ethereum/ens/ ?
I need to whitelist a couple of OZ governor and ERC20 contracts from different DAOs. Is it better to make one PR per DAO? or just a unique PR with all these changes?
Following up on @ntourne's question:
Tally is a dapp for interacting with DAO smart contracts. At Tally, we want to support EIP-712 signatures on token and Governor contracts for Uniswap, ENS, Gitcoin, and many more. Should we put those contracts into a single directory,
ethereum/tally/or into separate ones, likeethereum/uniswap/andethereum/ens/?
ethereum/tally please, thank you