LedgerHQ/ledger-live

[Bug]: Outdated celo dependencies

Closed this issue · 6 comments

Impacted Library name

ledger live common

Impacted Library version

latest

Describe the bug

The short message is that ledger-live uses an old version of @celo/contractkit and needs to move away from that version to continue working.

Why?

Some history: When celo launched as an alt L1 it used a custom transaction type that like eth legacy was a type 0 but with extra parameters. we call this celo-legacy type. While the celo chain now supports eth-legacy, type 2 and celo’s specific cip64 (gas token) transactions, @celo/contractkit@3.0 only supports celo-legacy transactions.

But celo-legacy transactions are deprecated and the next hardfork will completely remove support for them. Furthermore because the chain will remove support, the latest celo-ledger-spender app only supports cip64 and eip1559 transactions making it already incompatible with ledger live. An unfortunate situation we were not aware of until recently.

When is the hardfork?

Uncertain for celo mainnet (2 months) but the alfajores testnet is moving to L2 status by end of September.

Wait What is the Hardfork?

I say hardfork but is bigger than that as CELO is becoming an OP based Layer 2.This is why the transaction type is being removed. It is not being backported to the new stack.

"@celo/connect": "^3.0.1",
"@celo/contractkit": "^3.0.1",
"@celo/utils": "^3.0.1",
"@celo/wallet-base": "^3.0.1",
"@celo/wallet-ledger": "^3.0.1",

Expected behavior

upgrade to latest versions. eg 8.1.0 for celo/contractkit

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

this bot is hilarious

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

hey still working on this.

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

#8240 fixes this