Doesn't work with typescript < 4.1
hedgepigdaniel opened this issue · 4 comments
hedgepigdaniel commented
Due to at least this change: https://github.com/LeetCode-OpenSource/emotion-ts-plugin/pull/306/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R72
Perhaps its worth noting in the peer dependencies that typescript 4.0/4.1 (haven't tested if 4.0 works) is required?
Module build failed (from node_modules/ts-loader/index.js):
TypeError: Cannot read property 'createImportClause' of undefined
Brooooooklyn commented
What version of emotion are you using?
hedgepigdaniel commented
10.0.0.28, why?
Brooooooklyn commented
1.0 dropped emotion@10 supported. There were so many breaking changes in v11. So please use v0.x if you were using emotion@10.
hedgepigdaniel commented
Right thanks, will do.
So I guess the peerDependencies in package.json should be something like:
"@emotion/core": "^11.0.0",
"typescript": "~4.0.0", // ~ because typescript does breaking changes with feature releases