[Bug]: Blocked URLs accept HTTP and HTTPS URLs that are otherwise the same as separate entries
SleeplessOne1917 opened this issue · 1 comments
SleeplessOne1917 commented
Requirements
- Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
- Did you check to see if this issue already exists?
- Is this only a single bug? Do not put multiple bugs in one issue.
- Do you agree to follow the rules in our Code of Conduct?
- Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.
Summary
As described in the title. If you have https://somedomain/some_path, it will not cover http://somedomain/some_path.
Steps to Reproduce
- (Must be admin) got to site settings
- Enter both http and https versions of the same URL into the Blocked URLs textarea.
- Save changes
- Refresh page if updates doesn't show
- Check blocked URLs section again
Technical Details
n/a
Version
0.19.4-beta.4
Lemmy Instance URL
voyager.lemmy.ml
dessalines commented
As part of this , since we've already parsed them as urls, we could just keep everything past the domain. So even if a user saves https://google.com/....other_stuff
, as part of that validation function, it rewrites it to google.com/....