Fava terminal created regardless of runFavaOnActivate

[fancl20]

Fava terminal is created in the constructor of FavaManager:

  constructor(extension: Extension) {
    this._terminal = vscode.window.createTerminal('Fava');
    this._terminalClosed = false;
    this.extension = extension;
  }

IIUC, this will create a Fava terminal even runFavaOnActivate is set to false. Maybe we can set the terminal to close by default?

[Lencerf]

fixed in f8af0cc

[fancl20]

Verified. Thanks!