Lenz-K/arm64-kvm-hello-world

Stack misalignment

Closed this issue · 1 comments

Hi @Lenz-K,

Thank you for sharing your code. While your unmodified code works perfectly, I found that the stack setup in your linker script might be misaligned:

Based on Arm ABI(https://github.com/ARM-software/abi-aa/blob/main/aapcs64/aapcs64.rst#the-stack), the stack pointer should always be aligned to 16-byte(quad-word).

The current specific code works because the stack_top happens to be aligned to 16-byte but if some changes were made to the code or makefile, this could be broken.

This can be easily fixed by set alignment to 16.

Cheers!

Hi @XuhengLi,
Thanks for the feedback. I fixed it here: 5b72de8

Have a great day!