Level/level-ws

An in-range update of level is breaking the build 🚨

Closed this issue · 15 comments

greenkeeper commented

Version 2.0.0 of level was just published.

Branch Build failing 🚨
Dependency level
Current Version 1.7.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

level is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details
Commits

The new version differs by 26 commits.

  • efb9990 2.0.0
  • 64f5f47 Merge pull request #65 from ralphtheninja/master
  • bf0de16 options are passed to encoding-down (level-codec indirectly)
  • 27965de Merge pull request #63 from ralphtheninja/master
  • 9a8aef8 :arrow_up: bump level-packager
  • 1e1ef18 tweak readme (#62)
  • e4b04be Merge pull request #60 from Level/standard
  • 06902e3 standard: fix newlines at end of files
  • 6a4145d add standard
  • 100b134 Merge pull request #56 from Level/greenkeeper/leveldown-2.0.0
  • 5ff4e3d fix(package): update leveldown to version 2.0.0
  • 8a63d6b Merge pull request #55 from Level/greenkeeper/leveldown-1.9.0
  • 47a54c3 fix(package): update leveldown to version 1.9.0
  • 5438517 2.0.0-rc3
  • 19ceefa :arrow_up: bump level-packager to rc3

There are 26 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

greenkeeper commented

After pinning to 1.7.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper commented

Version 2.0.1 just got published.

Your tests are passing again with this version. Explicitly upgrade to this version 🚀

Commits

The new version differs by 3 commits.

See the full diff

greenkeeper commented

Version 2.1.0 just got published.

Your tests are passing again with this version. Explicitly upgrade to this version 🚀

Commits

The new version differs by 6 commits.

See the full diff

greenkeeper commented

Version 2.1.1 just got published.

Your tests are still failing with this version. Compare the changes 🚨

Commits

The new version differs by 9 commits.

  • f481db5 2.1.1
  • 08750c7 Merge pull request #72 from ralphtheninja/master
  • 1e23aba :memo: document .errors property
  • 60fb927 2.1.0
  • e91dccf Merge pull request #70 from ralphtheninja/master
  • 368f166 :arrow_up: bump dependencies
  • efa401f 2.0.1
  • d35a648 Merge pull request #67 from Level/restore-node-4
  • 970705a restore node 4

See the full diff

greenkeeper commented

Version 2.1.2 just got published.

Your tests are still failing with this version. Compare the changes 🚨

Commits

The new version differs by 10 commits.

  • 020ffae 2.1.2
  • 17f1d86 Open collective tweaks (#79)
  • dac447f Merge pull request #75 from opencollective/opencollective
  • d86046c fix markdown syntax
  • 0d8aabc Added call to donate after npm install (optional)
  • 1d9429a Added backers and sponsors on the README
  • 87aaf3e Added CONTRIBUTING.md (optional)
  • 0f7abc5 Added .github/ISSUE_TEMPLATE.md (optional)
  • 721c4a6 Merge pull request #73 from ralphtheninja/master
  • de0fb9e change travis badge from png to svg

See the full diff

greenkeeper commented

Version 3.0.0 just got published.

Your tests are still failing with this version. Compare the changes 🚨

Commits

The new version differs by 9 commits.

  • 064b549 3.0.0
  • 099cf88 Prepare v3 (#92)
  • 602aa78 add changelog and upgrade guide (#91)
  • ecaa938 readme: add table of contents (#90)
  • 93aee17 Merge pull request #89 from ralphtheninja/master
  • 2900172 readme: add note about node only
  • 98f6408 travis: add 9
  • 5fac721 Merge pull request #80 from Level/greenkeeper/leveldown-3.0.0
  • b625e07 fix(package): update leveldown to version 3.0.0

See the full diff

ralphtheninja commented

Hmm interesting. So the tests pass in 0.12 but not in any other version.

https://travis-ci.org/Level/level-ws/builds/342703200

I think the failed builds are expected, just wondering why it works in 0.12. Really no biggie since we shouldn't support 0.12, but still would like to know what's causing this.

vweevers commented

That's quite funny

ralphtheninja commented

So I checked that

https://github.com/Level/abstract-leveldown/blob/master/abstract-leveldown.js#L168

actually happens, the chain is

levelup.batch() -> encodingDown.batch() -> AbstractLevelDOWN.batch() but somehow the error doesn't propagate correctly, maybe due to differences in process.nextTick or something, but just guessing

ralphtheninja commented

If I replace

return process.nextTick(callback, new Error("`type` must be 'put' or 'del'"))

with

return callback(new Error("`type` must be 'put' or 'del'"))

then I get the same error on 0.12

ralphtheninja commented

Also, the following works

return process.nextTick(function () {                 
  callback(new Error("`type` must be 'put' or 'del'"))
})
vweevers commented

Ah. Node 0.12 does not support nextTick args.

  • 👍1
vweevers commented

BTW, the code here could use an update. The flushing etc would be much cleaner with a higher-level module like https://github.com/mafintosh/flush-write-stream.

ralphtheninja commented

Yes definitely. Make an issue on it?

  • 👍1