Wrong case of class variable inside `TinyCIFAR10DataModule`
ggalan87 opened this issue ยท 0 comments
๐ Bug
Prior to utilization of TinyCIFAR10DataModule I did a check on its (under review) code. ฮ realized that there is a bug/typo inside __init__
, where self.extra_args
variable is set:
This is in contrast to self.EXTRA_ARGS
which is already defined and used by the methods of the base class as required to pass the correct extra arguments to the underlying dataset:
lightning-bolts/pl_bolts/datamodules/vision_datamodule.py
Lines 105 to 106 in 2fdb818
A similar case that self.extra_args
is used is inside CityscapesDataModule, however there the implementation is self-contained and does not depend on base class for train_dataloader
and test_dataloader
.
Besides the bug, is there a motivation about why a capitalized version of the variable was preferred inside VisionDataModule?