LinkedInAttic/JTune

Jstat readings gets printed while using -n/--no-jstat-output arguments

Opened this issue · 1 comments

Arguments "-n"/"--no-jstat-output" can be used if we dont want to see the jstat output and to print only the summary
if my understanding is correct,
Please find below my finding
It suppresses only the header column and the jstat readings(calculated by script) still gets printed(I can send the pull request on you confirmation).
If my understanding is wrong, can you please give me more insights on this argument

Hi Eric

With the latest commit I am unable to leverage the functionality "-s, -y, -c" arguments when used along with "-n" argument.

When "-n" argument is used, jstat process is not executed and the gc log file is processed based on current size(when the jtune executes), and it just scans the available lines and doesnt looks for or validates the functionality "-s, -y, -c" arguments.

To me it looks like the previous code looked good however "run_jstat" function required few changes....

I would also like to let you know that with the previous code the "-n" argument had issues while using "-r" argument.

Please let me know your thoughts and suggestion