Remove -M in sar.sh?

[richardhsu]

Is it needed to have the -M flag for top in sar.sh? Ubuntu's version of top does not have this flag.

[zhenyun]

-M is not required I believe.
-M gives unit in memory summary (e.g., 65.89G rather than 65894020k), better human-readable
Does Linkedin use Ubuntu now? I suspect not.
Also, what are the output on Ubuntu? if it gives errors, we need to remove it.

[richardhsu]

I don't think LinkedIn uses Ubuntu but the troubleshoot guide shows a different Python development package for Ubuntu vs Red hat.

I don't know if we care to support but I think taking out -M will allow better support and allow the project to be more than just Red Hat.

The error is something like top doesn't have -M flag. So top output doesn't exist so you won't get those stats. Nothing huge but removing it allows top statistics to run fine.

[zhenyun]

for Naarad sar.sh, I think we can remove it. Please make the changes.
I will also send a request to remove -M in stat-collecotr sometime later (with other possible requests from us).

[RiteshMaheshwari]

Implemented in #260

[richardhsu]

#260 now merged.