Diff Report Chart Selection and Filtering

[richardhsu]

Diff report chart selection is broken.
Generates issue of innerHTML undefined on null object. The reason is that plot in naarad.js has changed and takes in 6 arguments rather than 5.

In report.html for Diff report:

<select id="select-chart-1" onchange="plot('select-chart-1','charting-div-1',0,false,'csv-url-div-1')">

In naarad.js which is common to normal reporting:

function plot(selector_id, reset_selector_id, div_id, colorset_id, advanced_source, url_div)

Quick hotfix is to just add the reset_selector_id to be the other selection box, i.e. select-chart-2 for the given example.

But I think for diff reports it'd be better to have the second selection box in this case select the same metric so both charts of same metric are shown. This would require some changes in functionality.

Second, we should add filtering as seen in normal reporting.

Summary:

1. Fix to have plot called correctly in Diff's report.html.
2. Add filtering on the selection boxes to Diff's report.html.

[richardhsu]

This issue ticket will refer to only the bug fix now since we want to have metrics to be able to be plotted. Currently the charting in diff report doesn't even work.

[richardhsu]

This was merged.