LinusU/react-native-get-random-values

Question: does it need "expo-random"?

hirbod opened this issue · 7 comments

Hey @LinusU,

I've seen so many confusing issues, docs and blogs on this topic but one thing I'm still unsure about: do we still have to install "expo-random" in Expo SDK 39 or is it enough to install your library now to polyfill?

Same question!

Sorry for the late reply! You do not need to install expo-random.

If there is anything that could be more clear in the documentation I would love a pull request!

Yeah, a hint about that fact :)

Looking thru the readme I don't see any mentioning of expo-random, what made you think that you had to install it? 🤔

Yes. I figured. Infact with expo-random it crashed on android.

Also it should be clearer where to import the module. It should be before everything else in index.js.

I'll submit a PR

Looking thru the readme I don't see any mentioning of expo-random, what made you think that you had to install it? 🤔

Coming from Expo Git and the original ticket issuing this problem and having a lot of mentions about expo-random from brent :D
At the end, the original expo ticket made me assume it.

added a comment in that thread: expo/expo#7209 (comment)