LinusU/react-native-get-random-values

Add support for Windows

dstaley opened this issue · 3 comments

dstaley commented

With React Native for Windows becoming a viable target, enabling this package for Windows would be a great benefit to the community! (Especially if this package backs uuid, since a library I plan on using in RN uses it.)

I'm willing to take a stab at an initial implementation, and wanted to post this issue as a place to track progress.

Todo:

  • Ensure RN for Windows supports synchronous methods It does!
  • Decide if C++ or C# would be the most appropriate C# would be the most approachable, and would be just as performant as the C++ version since they're both just calling UWP APIs
  • Determine if RN prefers Win32, UWP, or both for third party modules RN for Windows only works on Windows 10, so there's no sense in using the Win32 APIs.
  • Setup project (blocked by microsoft/react-native-windows#4211)
  • Rewrite module in C++ (blocked by microsoft/react-native-windows#4215)
ajnozari commented

Is there any update to this? I think there has been a resolution in those referenced issues.

alexanderblackh commented

Definitely adding a +1 to this. Any updates? The blocks on the final step appear to have been resolved.

  • 👍1
adamgorMSFT commented

It would be great to see progress on this issue.

Does look like #15 does try to address this.