LIP-0037 specifies ambiguous requirements for tags
ricott1 opened this issue · 0 comments
Current Specifications
LIP-0037 specifies message tags as strings with "LSK_" prefix, "_" suffix and content that is "a unique string indicating the scheme and, optionally, additional information." The content of a newly specified tag (specified outside of the LIP) "must contain only ASCII characters between 0x21 and 0x7e (inclusive), except that it must not contain underscore (0x5f)" according to the LIP.
The LIP specifies a set of message tags. One of these, named MESSAGE_TAG_CHAIN_REG_MESSAGE, has the tag with value LSK_CHAIN_REGISTRATION_. The tag violates the requirement of not having an underscore character except in prefix and suffix. As the requirement is only for "new" tags, the MESSAGE_TAG_CHAIN_REG_MESSAGE does not violate it. However, if the purpose of the requirement is to ensure domain separation for hashing, then the tag in question may cause security issues in the future anyway.
Affected LIPs
0037