Livestream/scredis

Some tests fail

Closed this issue · 12 comments

I run tests. And some of them failed. Next time all is green. Some random fails. Please, check out.

sbt> test
...
[info] RedisSpec:
[info] Redis
[info]   when issuing some commands with auto-pipelining enabled
[info]   - should end up executing them in a pipeline *** FAILED ***
[info]     Some("Hello World!") was not empty (RedisSpec.scala:51)
[info]   when selecting a different database
[info]   - should change the dabatase on all clients *** FAILED ***
[info]     Set("STR") was not empty (RedisSpec.scala:61)
...
[info] Run completed in 54 seconds, 355 milliseconds.
[info] Total number of tests run: 520
[info] Suites: completed 15, aborted 0
[info] Tests: succeeded 518, failed 2, canceled 0, ignored 0, pending 2
[info] *** 2 TESTS FAILED ***
[error] Failed tests:
[error]     scredis.RedisSpec
[error] (test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 79 s, completed Jun 24, 2014 2:46:19 AM

I have not been able to reproduce. Anyway, I'm actively working on version 2.0.0 which will be based on Akka's non-blocking TCP IO. I will make my best to make tests as resilient as possible.

OK. Feel free to close then. Good luck!

I made my best to stabilize the tests in 2.0.0-RC1 which has just been released. Feel free to have a look.

Some tests have not passed hidden_url

  • You are not using redis 2.8.13
  • You must not connect to the redis server externally otherwise it will interfere with the ServerCommandsSpec

OK. Version is updated.

Could you give an info on redis server is expected to be run then?

It's all written in the wiki.

You need to run redis-server 2.8.13.

OK. Thanks. I thought it is outdated and I am missing something.

Only one test is failed for me now

[info] CONFIG REWRITE
[info]   when the server is running without a config file
[info]   - should return an error *** FAILED ***
[info]     Expected exception scredis.exceptions.RedisErrorResponseException to be thrown, but no exception was thrown. (ServerCommandsSpec.scala:271)
[info]   when the server is running with a config file
[info]   - should succeed

Good work though!

It probably failed because you started the first redis-server with a config file.

Only the one with port 6380 and a password is supposed to be started with a config file.

You are absolutely right! I thought that shipped conf file is for default configuration. Seems like there is a difference. All tests are passed now!

Great, thanks for checking!