Any concern for using `math.sqrt` instead of `torch.sqrt`

Question

Any concern for using `math.sqrt` instead of `torch.sqrt`

wenmin-wu opened this issue 4 years ago · 2 comments

I find you use a lot of math.sqrt in your implementation. Any concern for not using torch.sqrt instead? I think math.sqrt is slower than torch.sqrt because it's on CPU.

Answer 1 · 2021-02-05T02:12:44.000Z

I believe since those computations take float numbers as inputs (instead of tensor), it should not be a problem.

Answer 2 · 2021-02-05T02:14:55.000Z

Got it, thanks