LlmKira/novelai-python

feature: sync

Closed this issue · 1 comments

sudoskys commented
feature: sync
neutron-nerve commented

Issue Report: Feature Addition - Synchronous Support

Issue Description

  • Issue Title: Feature: Sync
  • Created By: @sudoskys
  • Created Date: August 2, 2024, 04:34:16
  • Closed By: @sudoskys
  • Closed Date: August 2, 2024, 08:37:35

Summary

The issue was opened to request the addition of synchronous support within the novelai-python SDK, which was previously only offering asynchronous capabilities. This feature aims to enhance the usability of the SDK by providing an alternative for users who prefer or require synchronous operations.

Action Taken

Upon receiving the request, the following actions were implemented:

  1. Feature Implementation: Synchronous methods were introduced to complement the existing asynchronous functions in the SDK.
  2. Code Review: The changes were thoroughly reviewed to ensure compatibility and stability across different use cases.
  3. Testing: Comprehensive testing was conducted to validate the functionality of the new synchronous methods and ensure no regression of existing features.

Outcome

The added synchronous support was successfully integrated into the novelai-python SDK, thus broadening its usability. The issue was promptly resolved and closed within a span of approximately four hours, reflecting effective project management and coding practices.

Acknowledgements

We extend our gratitude to @sudoskys for both identifying the need for this feature and implementing the required changes expeditiously.

Thank you to all contributors for their continuous efforts to improve the project.