LoginRadius/ruby-on-rails-sdk

Integrating rubocop with gem

Closed this issue · 0 comments

anujc4 commented

I'm looking for some interesting projects to contribute to and stumbled across this one. The gem's implementation is great but I'm seeing a couple of rubocop offenses and duplicated code. Would you guys be open to a couple of changes:

  1. Add a rubocop.yml file and fix the existing offenses
  2. Refactor the code a bit to remove duplicated code (mostly present in request_client.rb). I can add specs if needed?