Lokathor/bytemuck

Derive gives `clippy::extra_unused_type_parameters` warnings

Kyuuhachi opened this issue · 4 comments

The derive macros generate stuff like

const _: fn() = || {
    #[allow(clippy::missing_const_for_fn)]
    fn check() {
        fn assert_impl<T: ::bytemuck::Pod>() {}
        assert_impl::<u8>();
    }
};

which triggers a clippy::extra_unused_type_parameters warning. Only way to suppress it is to #![allow()] it in the whole module.

Yeah I'd take a PR that puts an extra allow in the generated code.

Jarcho commented

fn assert_impl<T: ::bytemuck::Pod>() {} shouldn't be giving a warning in the first place. Only nightly releases from approximately Feb 9-23 should have had that bug.

Btw, clippy team fixed this issue, see rust-lang/rust-clippy#11014

Thanks, then we can close here I guess.