c_char regression in v1.0.8

Question

Closed this issue 3 years ago · 5 comments

Hey! Thanks for the useful crate.

Going from v1.0.7 to v1.0.8, the type of c_char is no longer correctly signed on aarch64-apple-ios.

Answer 1 · 2021-10-22T20:01:40.000Z

ahhghh, i double checked with my mac guy if i had it right and they said it was good!

Alright I'll try to fix it this evening.

Answer 2 · 2021-10-22T20:13:56.000Z

Actually @francesca64 I need to ask a follow up:
https://github.com/Lokathor/chlorine/blob/main/src/lib.rs#L94
this sets the type to be signed if the target_os is macos. I thought that ios targets also had macos as their os type. If not, what do they call their os type?

Answer 3 · 2021-10-22T20:23:21.000Z

Answer 4 · 2021-10-23T01:23:05.000Z

@francesca64 do you want to double check that #4 was what you expected before I publish the change?

Answer 5 · 2021-10-25T17:42:32.000Z

Looks good; thanks so much!