Accordion updates all arrows on click (OSOE-339)

Question

Accordion updates all arrows on click (OSOE-339)

devlife opened this issue 2 years ago · 7 comments

When clicking a single arrow/header, the correct item is expanded, but the arrows of all of the items are toggled.

I can take a stab at a fix if you can tell me how to override the cshtml file. I tried /Views/Shared/BootstrapAccordion.cshtml and /Views/Lombiq.HelpfulExtensions/BootstrapAccordion.cshtml but neither of those worked.

Jira issue

Piedone commented 2 years ago

Thanks!

Answer 1 · 2022-02-28T23:54:47.000Z

Thank you! BootstrapAccordion is a shape with its shape template, so just Views/BootstrapAccordion.cshtml should work.

Answer 2 · 2022-03-07T21:58:42.000Z

@Piedone My front end engineer updated the accordion to work with bootstrap 5. Do you want me to push a PR with those changes or just close this issue?

Answer 3 · 2022-03-07T22:32:35.000Z

Hmm, it should already work with it, specifically, Bootstrap 5.1.3. But please do and we'll see. (Actually, a Bootstrap reference seems to be missing from the shape.)

Answer 4 · 2022-03-08T13:42:02.000Z

Ok I'll create a PR for it in the next few days and we can see what you think.

Answer 5 · 2022-07-13T10:53:31.000Z

Would you like to circle back to this?

Answer 6 · 2022-10-24T16:16:57.000Z

This was previously fixed in https://github.com/Lombiq/Orchard-UIKit/pull/21/files#diff-7a8f5a66f070eea76f90e2b5ec052d8fb67eb4412e074226dd6cc86df6fc9c2f.