Lombiq/Open-Source-Orchard-Core-Extensions

Upgrade to Orchard Core 1.5 (OSOE-392)

Piedone opened this issue · 6 comments

Piedone commented

...once it's released.

  • Lombiq/UI-Testing-Toolbox#133 will need this.
  • Change services.AddScoped<IDataMigration, CustomMigrations>() calls to services.AddDataMigration<CustomMigrations>()
  • You'll get a "System.MissingMethodException: 'Method not found: 'System.Collections.Generic.IDictionary`2<System.String,NLog.Layouts.SimpleLayout> NLog.Config.LoggingConfiguration.get_Variables()'.'" exception until the UI Testing Toolbox's NLog version is not the same as that of Orchard's.

Jira issue

MZole commented

I'm facing some issues with the SQL server tests, the tests can't pass the setup page, and I'm getting this error message:

image

This is not happening locally, I can run the tests and they pass the setup page. I have added the recommended extra stuff to our connection string (Encrypt=False; TrustServerCertificate=True) but if I remove them, I get the same error locally.

I've tried to find out what changed, and I could only find this but I'm not sure if this is relevant to us.

Also, some visual verifications fail on the VerifyHomePage test, I saw that if I delete the image, a new baseline image will be generated on the next run, I'm guessing I will be able to download that image and paste the new one in our tests folder, am I correct?

Piedone commented

The connstring changes are necessary, so that's not an issue.

Yes, but do check if the changes on the homepage are indeed normal.

  • 👍1
sarahelsaig commented

That problem with SQL Server connection string will also arise in the GHA.
I've already fixed that in OSOE-403, so you should merge or cherrypick from there.

  • 👍1
MZole commented

Thank you! I was wondering why the connection string didn't change on the tests 😁.

MZole commented

Just a quick update, this is almost done. As I understand it, I will have to open another PR for the NuGet solution update since it references our projects via NuGet, after we publish NuGet releases of the projects.

Only one test fails on Windows, the IdleTenantTests but it passes on Linux. I have checked out the failure dumps, and the log file shows that the tenant is shutting down, so this will take a bit more time for me to figure out what's causing this issue.

Piedone commented

Great!

You'll need to publish issue-specific alphas of all projects and update the references in the NuGetTest solution right away. However, we can leave that as a last step when all the PRs are approved, so you don't need to publish them repeatedly if changes are needed.

  • 👍1