Longwelwind/swords-and-ravens

Missandei and Lysa Arryn MoD are not resolved properly when they are played as last card

Closed this issue · 1 comments

Currently the game performs house card handling (discard played card and recycle deck) before after-winner-declared abilities are resolved.

According to the rules, this is the correct order:

image
image

With the base game only, this actually was no big issue at all. But with the addition of the Mother of Dragons expansion the order matters for Missandei and Lysa Arryn. When they are played as last card the current implementation leads to incorrect behavior. The issue is, that we discard Missandei (respectively Lysa) and recycle the deck before their abilities are triggered. In case of Missandei it means, she cannot be used at all because then there is no other card than herself on the discard pile. Actually she should be able to return another card first and prevent a card recycle that way. It could make sense if players don't want to use Missandei as last house card.
For Lysa Arryn, it is even much worse. Currently, the deck is recycled and then the player is asked if he wants to keep Lysa in hand, which means that he then has all 7 cards available again, whereas the correct behavior would be to either keep only Lysa and prevent card recycling or actually discard her and return the 6 other cards.

However, a fix for this bug is very problematic:

When we reorder post-combat resolution all running PBEM games which are in post-combat state will either become invalid because an already performed resolve-casualties could be repeated, or even worse, an already performed retreat is triggered again and will crash the game. I see no way to migrate this properly so the only chance to solve it will be to pause all games which are not in combat, wait until no more game is in combat, release the fix and then continue the games.

Temporarily we'll show this warning in-game:

image

and list the in-combat games on the Games page:

image

Remember:

  • Notify all waited players again, when games are resumed.