Script class initialization is way too slow

Question

Script class initialization is way too slow

Fiusen opened this issue 3 years ago · 2 comments

Fiusen commented 3 years ago

Loretta's Script class initialization of a big script takes way too long:

Time on a 20MB file:

```
  Script init: 9s
```
```
  Parse time: 0.9s
```

How to replicate:

Have a random script (like allopcodes-5.1.lua) and copy and paste it until ur file gets to ~20MB

var scriptParsed = new Script(ImmutableArray.Create(LuaSyntaxTree.ParseText(code)));
var root = Parsed[0].GetRoot();

SyntaxNode node = root.ChildNodes().FirstOrDefault(); // whatever

scriptParsed.GetScope(node) // long wait here

Answer 1 · 2022-03-16T00:00:25.000Z

After quite a bit of profiling, this is not gonna be possible without rewriting the entire scoping code.

Most of the code is being spent in unmanaged code which means that most of the time is probably being spent in array resizes of dictionaries' backing buckets and hashsets' backing buckets and/or virtual calls.

Answer 2 · 2022-07-18T15:37:42.000Z

Closing this since #32 will fix this indirectly.