enhanchment merge CHECK_FOR_REDIRECTS, CHECK_FOR_REDIRECT_CHAINS, MAX_REDIRECT_CHAIN_DEPTH
Closed this issue · 2 comments
As all these value basically do the same thing i suggest to merge all in a single env, probably the MAX_REDIRECT_CHAIN_DEPTH is enough:
MAX_REDIRECT_CHAIN_DEPTH=0 disabled
MAX_REDIRECT_CHAIN_DEPTH=1 similar to have CHECK_FOR_REDIRECTS to true (check just the first redirect)
MAX_REDIRECT_CHAIN_DEPTH=2 (or any >1), actual behaviour of max redirect to follow (but witouth the need to set also CHECK_FOR_REDIRECT_CHAINS)
A similar thing can be done with SHORTEN_LINKS and BITLY_TOKEN
That's very reasonable, but there's a reason I kept them separate, especially SHORTEN_LINKS: it's easier to turn on/off each feature with the boolean while at the same time keeping its "setting" (MAX_REDIRECT_CHAIN_DEPTH and BITLY_TOKEN) set to the desired value.
For this reason, I don't think I'll change this in the future.