Changes to aesthetic scores don't trigger new generation with KSampler Advanced until ComfyUI restart
alessandroperilli opened this issue · 3 comments
I'm not 100% sure this is about the KSampler Advanced node, but I'll flag it anyway.
In the following situation, with a fixed seed, a change in the aesthetic score
values entering the CLIPTextEncodeSDXLRefiner
node, won't push the KSampler Advanced
node to generate a new refined image. It will simply regenerate the same image, as if no parameter was changed.
![Screenshot 2023-10-26 at 10 23 55](https://private-user-images.githubusercontent.com/9775949/278282996-6d8e6b75-3de7-4a2b-bcdf-e41ea667d2ec.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM1NDMwNTksIm5iZiI6MTcyMzU0Mjc1OSwicGF0aCI6Ii85Nzc1OTQ5LzI3ODI4Mjk5Ni02ZDhlNmI3NS0zZGU3LTRhMmItYmNkZi1lNDFlYTY2N2QyZWMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTNUMDk1MjM5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTQ2ZDJjZjcxMGIzNzhiOTdhYzM2MTA2MTFhY2VkYzkxYjY1YzA5ZWEwZmQ0ODM0YzgyODIyNzE5Y2NlYjMyOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.E_q374-S54NrZgg6JyyQ6qhXbK7jD3VniUz6BEkpnh8)
To force the generation of an image that takes into account the modified aesthetic score values (all other things equal), I have to interrupt ComfyUI and restart it. As if something gets cached when it shouldn't*.
*I have a similar problem when I change the VAE in the Efficient Loader
node: if I change the VAE setting from baked VAE
to a specific VAE file, that is taken into account during the new generation. However, if I revert back to backed VAE
for the subsequent generation, ComfyUI still tells me that it's using the specific VAE file. I have to interrupt ComfyUI and restart it to see the correct VAE setting being picked up.
It feels like something is aggressively cached when it shouldn't.
I have a similar issue with the Efficient Ksampler, with fixed seed, when i change a control nets' strength it doesn't update the image. With the default Comfui Ksampler it does.
Also experiencing this issue where Controlnet Stack strength change does not take effect until ComfyUI restarts when using Efficient KSampler (SDXL).
I also have the issue with adv controlnet apply.