breaking CI on PR's
Opened this issue · 3 comments
you say
Don't break the package, continuous integration builds should not fail for your Pull request.
may want to give a caveat that PR's may fail and it won't be their fault as PR's don't have access to env vars set by the admin on the repo - e.g. if there's an API key for a web API
@LucyMcGowan slightly related to this maybe we should add a link to resources mentioned in this discussion
That said I don't think any of them is a friendly introduction guide to R packages... I mean it's a bit intimidating to have a whole book to read. I know this blog post was very successful.
Or maybe we expect people to have read a bit on their own before actually deciding they want to contribute to a package.
do you think we should link to the discussion & Hilary's post in the Starting Guide? Or were you thinking of listing resources that are discussed in the discussion?
Listing resources in the starting guide, I can add them if you want, but only if it is not too intimidating (I think it's not?)