glslang master ENABLE_OPT CMakeLists.txt option needed

Question

glslang master ENABLE_OPT CMakeLists.txt option needed

danginsburg opened this issue 7 years ago · 4 comments

The newest version of glslang master adds ENABLE_OPT which defaults to ON. LunarGLASS CMakeLists.txt needs to be updated with this option and include SPIV-Tools, SPIRV-Tools-opt, and SPVRemapper when it's enabled. Right now it gets a link error.

Answer 1 · 2017-10-03T16:09:14.000Z

Thanks Dan. You can submit your patch as a PR or push a branch and I can submit the PR. Whatever you would prefer.

Answer 2 · 2017-10-03T17:15:16.000Z

Should be fixed by the PR.

Answer 3 · 2017-10-24T14:45:34.000Z

Sorry, I discovered my PR had an error. This:

append(GLSLANGLIBS SPVRemapper SPIRV-Tools SPIRV-Tools-opt)

should be this:

list(APPEND GLSLANGLIBS SPVRemapper SPIRV-Tools SPIRV-Tools-opt)

I can file a new PR if needed. Sorry for the churn.

Answer 4 · 2017-10-24T15:38:56.000Z

Since you have the best understanding of this code at the moment and are probably have everything set up to test it, it would probably be most efficient for you to submit the PR. Thanks!