Adding showHours prop adds an extra letter in the time stamp
esegebart opened this issue · 6 comments
The showDuration prop works perfectly.
When I add the showHours prop, it shows this:
I could reproduce this.
Here is where we calculate the time: https://github.com/criszz77/react-native-media-console/blob/master/src/utils.ts#L45-L76
Should be an easy fix.
Well I will give it a shot! :)
It would be this right here, right? Should be a zero where the "a]" is?
After you fork the repo and make your changes you will have to run yarn prepare. You can test it by running yarn add [path to the forked repo] in your app project (be sure to delete node_modules from forked repo). An easy way to get the path is to right click on the forked repo folder, press Option and keep it pressed, then select Copy react-native-media-console as Pathname.
If you run into issues, let me know, I'll be more than happy to help.
It would be this right here, right? Should be a zero where the "a]" is?
I tested it and it seems to work, however, I don't have a video that long to test correctly 🙈
@criszz77 Awesome!!! That was my first pull request on a project!
Haha thank you! I am very happy as well :D