Invalid footer link [Add a status code]

Question

Invalid footer link [Add a status code]

AkashRajpurohit opened this issue 4 years ago · 6 comments

The current link in footer points to https://github.com/M0nica/httriri#adding-a-new-status-code/ rather it should be https://github.com/M0nica/httriri#adding-a-new-status-code Without the trailing slash

With the trailing slash it does not scroll to the exact place it is intended to go when redirected to github.

Answer 1 · 2020-10-03T11:33:20.000Z

@AkashRajpurohit thanks for flagging this. Are you interested in submitting the fix?

Answer 2 · 2020-10-03T11:37:47.000Z

@M0nica Sure, although if someone else wants to take the opportunity to learn how to send PRs to open source then i'll be happy to assist him/her for this.

If no one else is taking, i'll send the PR 😄

Is that okay with you?

Answer 3 · 2020-10-03T11:50:25.000Z

Is it fine if i fix the issue ? I had added the link originally and i kinda messed up it seems😅

Answer 4 · 2020-10-05T03:12:21.000Z

This issue is still available however I defer to @AkashRajpurohit since they commented first so it would be great if you all could coordinate amongst yourselves.

Answer 5 · 2020-10-05T03:59:32.000Z

Ok no problem @AkashRajpurohit can do this fix. I'll try working on the unit tests

Answer 6 · 2020-10-05T04:53:34.000Z

Cool, will send the fix PR.