Make parameter values in submodels unique to fix duplicate variable names in traces

Question

Make parameter values in submodels unique to fix duplicate variable names in traces

Opened this issue 5 years ago · 2 comments

Answer 1 · 2021-01-24T08:25:24.000Z

Is this resolved with the _param_name method or is there additional work to do?

Answer 2 · 2021-01-25T07:59:14.000Z

this is already fixed with the _param_name, yes. I did recently discover though that you can have nested PyMC3 models with namespaces that could also solve this issue. In the definition method, we could do the following:

def definition(self, model, X, y):
    with pm.Model(f'FourierSeasonality({self.n}, {self.p})', model):
         // Do the normal PyMC stuff here

I'm not sure what the pros and cons to either are yet though.