MESAHub/mesa

possibly outdated controls.defaults

mathren opened this issue · 1 comments

Hello! I was looking into controls.default and found this (to me very interesting option):

      ! mass_depth_for_L_surf
      ! ~~~~~~~~~~~~~~~~~~~~~

      ! only if ``use_flux_limiting_with_dPrad_dm_form``

      ! ::

    mass_depth_for_L_surf = 0d0

However, searching the code base for mass_depth_for_L_surf or use_flux_limiting_with_Prad_dm_form, they seem to appear only in ctrls_io.f90. This + the name hinting at flux limited diffusion makes me think this is an old option that cannot be used anymore.

Thanks! You're right, that's leftover and should be removed. Looks like this was most recently functional in release r12778. A few revisions later in the svn history shows:

------------------------------------------------------------------------
r12800 | bpaxton | 2020-03-11 14:59:58 -0400 (Wed, 11 Mar 2020) | 2 lines

remove flux limiter and porosity factor

@aurimontem might be able to offer some insight into how those options might have been used at one point and/or why they were removed?