Log filter not working proper
Closed this issue · 22 comments
Bug report
- ShowsRage version: latest beta from 23/08
- Android version: 4.2.2
- Device: Galaxy S4
Issue description
Choose thread: FINDSUBTITLES
Change log level: DEBUG
Expected result
Sees debug levels + info levels to FINDSUBTITLES only
Seems changing filter is reseting level
also changing level is reseting filter
I confirm that changing the log level reset the filter. I will fix it before the public release.
However, I am not sure about the first point (changing filter is reseting level). I will check that.
I found the cause of the issue. It will be fixed when I release the public version 1.5.
@MGaetan89 thanks!
we fixed - thanks to @ratoaq2 Medusa log (PR still open) too so we won't see those bunch of API logs
I saw the PR yes, it's not a bad idea.
Will you still keep the "API Access granted" logs?
@MGaetan89 i dont think so. why do you need it?
I running ShowsRage with that branch and logs appear ok.
@ratoaq2 can confirm
I don't need. Just thought it might be useful to know when someone is accessing SickRage with the API.
@MGaetan89 do you have an APK so i can test the fix before pushing to play store?
Not yet. I can do an extra beta version first if you prefer.
Would be nice. Just to confirm its fixed.
I'm waiting for Travis result in #100 and then I'll push a new beta version on the Play Store.
I just pushed a new beta version. You should receive it in the next hour.
@MGaetan89 thanks! will let you know
Updated but still something is wrong:
From logs:
2016-08-26 16:37:43 INFO FINDSUBTITLES :: [555b0cb] No subtitles to download
2016-08-26 16:37:43 INFO FINDSUBTITLES :: [555b0cb] Checking for missed subtitles
ShowsRage:
3 days ago? Only INFO?
Another: see how log jumps from minutes to hours:
Is clearly mising a LOT of logs
I don't have time to properly investigate this issue for the moment, so I disable the logs filter until the next version.
Can you test the attached APK to see if you are still missing some logs? (GitHub does not support attaching APK, so I just changed the extension to zip. Change it back to apk before installing it).
It jumps from 1hour to 3 days
I guess it's because I store logs locally, and don't clean them if they are cleared in SickRage (manually or after an update).
Does SickRage API returns more logs or does it only return two entries for INFO log level?
I will make sure that I only store what SickRage returns to prevent this.
imo you shouldn't store logs, just show what SickRage/Medusa sends.
I'm trying to stay feature-full when offline/disconnected from SickRage.
I updated the logs storage to better reflect what SickRage sends.
I am waiting for Travis to finish running the tests, and then I'll release the new version.
I'm closing this for now, as it is not part of version 1.5.
Don't hesitate to open a new issue for 1.6 if the problem if still there.
@MGaetan89 looks like its working (i missed where you tagged me about the update so im writing here)
I noticed some old logs from 2 months ago. Refresh page doesn't make then go away (cached maybe?) only changing any filter
confirm?
personally i think caching log is not really needed.
Sorry for the delay...
Maybe try to refresh each log level (debug/info/warn/error) to see if old logs go away. If they don't. There might still be an issue.