Update Foundry example notebooks Globus download flags

Question

Update Foundry example notebooks Globus download flags

Closed this issue a year ago · 3 comments

Answer 1 · 2024-01-19T04:35:35.000Z

Each notebook has logic as below

try:
    import google.colab
    no_local_server = True
    no_browser = True
    globus = False
except: # when not in google colab
    no_local_server = False
    no_browser = False
    globus = True

This combines the logic for choosing the auth path with choosing the download path. I think we should set globus=False in both cases by default, and have a commented out globus=True path that explains what it does. e.g., as below

try:
    import google.colab
    no_local_server = True
    no_browser = True
    globus = False
except: # when not in google colab
    no_local_server = False
    no_browser = False
    globus = False


# If you would like to use Globus to download the data, ensure you have an endpoint running, and uncomment the following line
# globus = True

Answer 2 · 2024-01-24T16:00:36.000Z

Looking at the larger picture, should we default to globus=False if the user doesn't pass in a globus parameter when initializing? Would that simplify things?

Answer 3 · 2024-01-24T16:06:25.000Z

globus=False is the default now. That's actually what caused the breaking change. Since we pass globus variable to all the class inits in the notebook, I think setting it here explicitly is a shorter path than updating everywhere.