MPAS-Dev/MPAS-Model

Recent mods from MPAS-JEDI

Opened this issue · 5 comments

snyderdad commented

Here's a consolidated list of modifications from JCSDA-internal/MPAS-Model that we hope to merge with MPAS-Dev/MPAS-Model. All except cmake build are specific to core_atmosphere or core_init_atmosphere.

  • Enable core_init_atmosphere to use mpas_new_unit and mpas_release_unit instead of fixed file unit numbers. See JCSDA-internal#12. Handled by PR #988 .
  • Add optional parameters to the mpas_init signature, allowing the caller to pass in a namelist and/or streams filename, identical to the functionality already present when using the -n and -s command-line parameters. See JCSDA-internal#10. @svahl991 Handled by PR #990 .
  • Cloud fraction and cloud height diagnostics. See #733 from @jamiebresch.
  • "2-stream I/O". This splits input streams into static and time-varying variables, as in an earlier branch from Ha, Skamarock. Also reduces the number of variables for I/O relative to a restart file and includes logic to manage the I/O, both similarly (but not identical) to Ha, Skamarock branch. See JCSDA-internal#5. @junmeiban, @liujake
  • adjoint of halo exchange. See JCSDA-internal@b22c340. @byoung-joo Handled by PR #1138
  • bug fixes in core_init_atmosphere for initializing rho_zz and xice. @liujake (#829 addresses part)
  • optional cmake build process and dependence on the jedi-cmake repository. See https://github.com/JCSDA-internal/mpas-bundle/pull/64. @svahl991
  • Modify cmake build procedure to disable OpenMP. See JCSDA-internal#11.

PR for 2nd through 5th changes on list into JCSDA-internal/MPAS-model is JCSDA-internal#8. @jjguerrette (Edit: @mgduda changed the order, so 2nd through 5th may not correspond anymore...)

Aim is to merge these into MPAS-Dev.

mgduda commented

As PRs are created to handle the modifications listed in this issue, it might be helpful to reference this issue in the description of the PR.

svahl991 commented

Here's a consolidated list of modifications from JCSDA-internal/MPAS-Model that we hope to merge with MPAS-Dev/MPAS-Model.

An addition to the list:
Add optional parameters to the mpas_init signature, allowing the caller to pass in a namelist and/or streams filename, identical to the functionality already present when using the -n and -s command-line parameters. See JCSDA-internal#10.

jjguerrette commented

The cmake build procedure is modified to disable OpenMP in JCSDA-internal#11.

jjguerrette commented

JCSDA-internal#12 enables core_init_atmosphere to use mpas_new_unit and mpas_release_unit instead of fixed file unit numbers

jjguerrette commented

Additional JCSDA-internal PR's since the list was last updated are as follows...