Quotes removed in setup_command
Closed this issue · 11 comments
The setup command line of each build is stored in setup_command for future reference. However, when more than one option is passed to cmake via the --cmake_options flag, the sting is stored without hyphens --cmake_options=-Doption_a -Doption_b. The right command line should contain --cmake_options='-Doption_a -Doption_b'.
I guess it has to do with the handling of such a string by python.
I think we hit this problem 2-3 years ago with @bast and the conclusion was that it's actually the shell that handles quotes, not Python. So it's next to impossible to do what you ask in a consistent manner.
Can we put a "reminder" in a separate line?
Something like:
./setup option option option
WARNING: remember to add missing quotes if necessary
It would spare us some time, considering that we will eventually forget that, given that it happens with the frequency of a leap year.
This is where we already wrestled with it: dev-cafe/autocmake#169
What I suggest as a "patch" is simply to append the WARNING line in the file setup_command. This should be doable, or?
Warning is definitely doable. I will again look at this issue.
But don't work in shifts for it, OK? ;-)
But don't work in shifts for it, OK? ;-)
We have a team on it.
I looked at it again and here are my findings: dev-cafe/autocmake#169 (comment). So there might be a solution.
There is a solution: dev-cafe/autocmake#264 - once this is in, it will require that you regenerate setup.
@ilfreddy Radovan's fix in dev-cafe/autocmake#264 has now been merged. You should regenerate
the setup script:
cd cmake
python update.py --self
python update.py ..
and try again.