MRChemSoft/mrcpp

Static code analysis (MRCpp)

Opened this issue · 1 comments

compiling mrcpp yields some compiler warnings in Fedora 35. The most common issue appears to be the comparison between signed and unsigned which arises from the use of int as loop indices checked against .size() which returns the size type, size_t. The loop indices could probably be all switched to size_t, what do you think?

Additionally, running static code analysis on the repository yields unclean results; output from cppcheck 2.6 attached
cppcheck.log
.

Thanks for reporting, I will have a go at this next week