[REQUEST] Introduce 'colorPositive' and 'colorNegative'
Closed this issue · 1 comments
Is your feature request related to a problem? Please describe.
MSU currently offers the functions colorGreen and colorRed with the intention for them to be used to color positive and negative values.
Unfortunately these names are a poor choice for this use case because they do not color a text green or red. They color it with whatever color is defined behind ::Const.UI.Color.PositiveValue and ::Const.UI.Color.NegativeValue. When for example a color blind person decides that they need different colors for these types of values then the function names become wrong.
A modder who wanted a text to be green using the colorGreen function will now have the text in another color that they didn't plan for.
Describe the solution you'd like
- Introduce colorPositive and colorNegative functions that are functionally identical to the current colorGreen and colorRed functions just with a new name
- Deprecate colorGreen and colorRed
Describe alternatives you've considered
Alternatively to deprecating the above functions you could change them so that they always force green or red color onto the text and no longer use ::Const.UI.Color.PositiveValue and ::Const.UI.Color.NegativeValue as reference.