MT-CTF/capturetheflag

Water flow on barrier removal not working on Plains of the Past

Emojigit opened this issue · 4 comments

As reported by @HobbitPower in a Discord message,

btw @Emojigit idk why but for the Plains of the Past map the 'barrier water bug' is still the case. For other maps with water it just worked fine.

The content ID of the water sources in Plains are normal, so there is nothing to do with the map placement. The reason is still unknown.

Reason found: Barrier area parameter in map.conf limited the loaded area. As we are checking water source blocks only within the loaded area, water sources are not detected and hence, not generated in barriers.

Probably need to fix this when we do map-calculated barrier removal

Probably need to fix this when we do map-calculated barrier removal

I have a fork branch where I am working on barrier nodes that turn into water, lava or air without checking for adjacent liquids. This will be a performance boost and fixes this problem.

That fork branch can also fix edge cases of water flow, e.g.: (W = Water, B = Barrier, O = Solid blocks)

W|W|W
B|B|O
W|O|O

The middle block, with the old checks, cannot turn into water. With the water barrier nodes, it can be transformed into water after barrier removal.

Should be fixed now