MaJerle/lwmem

error in lwmem.h

liuhao1946 opened this issue · 4 comments

liuhao1946 commented

Hi, I think your library works fine，Thank you very much. However, there is a small error in lwmem.h at line 204.

The original definition
#define lwmem_get_size(ptr) lwmem_get_size(NULL, (ptr))

The correct definition
#define lwmem_get_size(ptr) lwmem_get_size_ex(NULL, (ptr))

liuhao1946 commented

There is one more small problem. In lwmem.h, line 39 of the source code reads.
#include "lwmem/lwmem_opt.h"

As lwmem_opt.h is in the same directory as lwmem.h, it might be better to write it directly like this to prevent compilation path errors
#include "lwmem_opt.h"

  • 😕1
MaJerle commented

There is one more small problem. In lwmem.h, line 39 of the source code reads. #include "lwmem/lwmem_opt.h"

As lwmem_opt.h is in the same directory as lwmem.h, it might be better to write it directly like this to prevent compilation path errors #include "lwmem_opt.h"

It is expected that compiler sees path to include folder and then the rest resolves through relative paths. There will be no error.

edieruby commented

Hi, I think your library works fine，Thank you very much. However, there is a small error in lwmem.h at line 204.

The original definition #define lwmem_get_size(ptr) lwmem_get_size(NULL, (ptr))

The correct definition #define lwmem_get_size(ptr) lwmem_get_size_ex(NULL, (ptr))

This error is fixed in develop branch.
Is there a plan to release a version in main branch?