Mac-Nerd/patchomator

Issue with passing the LOGO options to Installomator when path contains a space

palexisd opened this issue · 2 comments

sudo /usr/local/Installomator/patchomator.sh --install --yes -q --ignored "dialog firefox firefox_da firefox_intl firefoxpkg_intl firefoxesr firefoxesr_intl googlechrome googlechromeenterprise slack zoomclient zoomgov" --options "BLOCKING_PROCESS_ACTION=prompt_user PROMPT_TIMEOUT=150 NOTIFY=slient LOGO=/Library/Application\ Support/Dialog/Dialog.png"
Password:
(eval):5: parse error near InstallomatorOptions...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 188k 0 188k 100 16 35590 2 0:00:08 0:00:05 0:00:03 47326
2024-02-29 13:48:04 : REQ : wireshark : ################## Start Installomator v. 10.5, date 2023-10-15
2024-02-29 13:48:04 : INFO : wireshark : ################## Version: 10.5
2024-02-29 13:48:04 : INFO : wireshark : ################## Date: 2023-10-15
2024-02-29 13:48:04 : INFO : wireshark : ################## wireshark
2024-02-29 13:48:05 : INFO : wireshark : setting variable from argument IGNORE_APP_STORE_APPS="no" LOGGING="INFO" SYSTEMOWNER="0" NOTIFY_DIALOG="1" NOTIFY="success" INTERRUPT_DND="yes" LOGO="appstore" REOPEN="yes" BLOCKING_PROCESS_ACTION="tell_user" PROMPT_TIMEOUT="86400"

It seems to be related to this :
image

and this :
image

give the latest source a shot. It may still require further escaping of spaces.

The LOGO option is now being passed correctly with the same command :

sudo /usr/local/Installomator/patchomator.sh --install --yes -q --ignored "dialog firefox firefox_da firefox_intl firefoxpkg_intl firefoxesr firefoxesr_intl googlechrome googlechromeenterprise slack zoomclient zoomgov" --options "BLOCKING_PROCESS_ACTION=prompt_user PROMPT_TIMEOUT=150 NOTIFY=slient LOGO=/Library/Application\ Support/Dialog/Dialog.png"