MadLamprey/ip

Sharing iP code quality feedback [for @MadLamprey] - Round 2

Opened this issue ยท 0 comments

@MadLamprey We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, so that you can avoid similar problems in your tP code (which will be graded more strictly for code quality).

IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most three example are given i.e., there can be other areas/places to improve.

Aspect: Tab Usage

No easy-to-detect issues ๐Ÿ‘

Aspect: Naming boolean variables/methods

No easy-to-detect issues ๐Ÿ‘

Aspect: Brace Style

No easy-to-detect issues ๐Ÿ‘

Aspect: Package Name Style

No easy-to-detect issues ๐Ÿ‘

Aspect: Class Name Style

No easy-to-detect issues ๐Ÿ‘

Aspect: Dead Code

No easy-to-detect issues ๐Ÿ‘

Aspect: Method Length

No easy-to-detect issues ๐Ÿ‘

Aspect: Class size

No easy-to-detect issues ๐Ÿ‘

Aspect: Header Comments

Example from src/main/java/bruno/task/Deadline.java lines 23-27:

    /**
     * {@inheritDoc}
     * @return String representation of the task.
     * @throws DateTimeException Thrown if the 'by' LocalDateTime cannot be converted to string.
     */

Example from src/main/java/bruno/task/Deadline.java lines 32-34:

    /**
     * {@inheritDoc}
     */

Example from src/main/java/bruno/task/Event.java lines 26-30:

    /**
     * {@inheritDoc}
     * @return String representation of the task.
     * @throws DateTimeException Thrown if LocalDateTime values 'from' and 'by' cannot be converted to string.
     */

Suggestion: Ensure method/class header comments follow the format specified in the coding standard, in particular, the phrasing of the overview statement.

Aspect: Recent Git Commit Message

No easy-to-detect issues ๐Ÿ‘

Aspect: Binary files in repo

No easy-to-detect issues ๐Ÿ‘


โ— You are not required to (but you are welcome to) fix the above problems in your iP, unless you have been separately asked to resubmit the iP due to code quality issues.

โ„น๏ธ The bot account used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact cs2103@comp.nus.edu.sg if you want to follow up on this post.