Use stdin instead of writing a temp file
Closed this issue · 9 comments
bdelespierre commented
using proc_open
we can pipe the content of the compiled string into php -l
thus saving us the hassle of creating temporary files.
bdelespierre commented
Leave it to me I'll make a PR 👍
Magentron commented
I'm not so sure whether this is actually an improvement as some installations may not have this function available (e.g. shared hosting environments where this has been disabled via disable-functions.
bdelespierre commented
Such environment won't have exec
either when you think about it.
bdelespierre commented
And why would you want to run this script on shared hosting in the first place 🤷♂️
Magentron commented
Makes sense, please submit the PR and I'll review it. Thanks in advance.
bdelespierre commented
On it.
bdelespierre commented
Here it is #3
bdelespierre commented
Great thanks 👍