set.getCards() returns null in v0.0.10

Question

set.getCards() returns null in v0.0.10

Closed this issue 6 years ago · 6 comments

Lakuna commented 6 years ago

The project I'm currently working on in which this is an issue is here:

https://github.com/T3rrabyte/MTGDS

Answer 1 · 2018-11-18T02:52:42.000Z

Is this all sets or a specific set you are getting the error with?

Answer 2 · 2018-11-18T03:15:22.000Z

Every set.

Answer 3 · 2018-11-18T03:16:25.000Z

Okay, I will take a look hopefully tonight or tomorrow, and will update with additional information as needed.

Answer 4 · 2018-11-18T03:18:04.000Z

Thank you for the quick response!

Answer 5 · 2018-11-18T05:53:41.000Z

I did not realize you are using getAllSets().get(index).getCards; I am not sure if the rate limits on the api will allow for getting all sets and referencing the cards that way. I am building out a test currently and going to give it a run. It will also drastically slow down the performance of getAllSets, so I may be adding a new method of getAllSetsWithCards();

Answer 6 · 2018-11-18T06:51:55.000Z

Should be fixed in ae007cf which will be appearing as v0.0.11. There will be a future v0.0.12 release that will also add this functionality to a filter get all sets.