shell_v2 for remote devices
realdadfish opened this issue · 1 comments
I'm not actually using adam as of now, but have my own adb-shellout stuff baked in my test code to talk to (remote) devices and emulators, but I stumbled upon a serious issue which I think makes me unable to continue using adb.
The issue is the "command line too long" error that happens when I try to process very long command lines via adb shell. This works nicely for locally connected devices that return shell_v2 from adb features when connected, but fails with the aforementioned issue as soon as I try to process the same command via a remote device connected with adb connect.
I think the culprit is this line: https://cs.android.com/android/platform/superproject/+/master:packages/modules/adb/client/commandline.cpp;l=621;bpv=1;bpt=1?q=%22shell%20command%20too%20long%22
Problem seems to be that adb features of a remotely attached device does not return any features at all, and since shell_v2 is then also obviously missing, adb resides to turn to the old PAYLOAD_V1 limit which is only 4k (as opposed to 256k with PAYLOAD_V2).
Do you see a chance that your library could circumvent this problem and would allow longer command lines to be sent to remotely connected devices?
Ok, your implementation seems to do what I need, closing this. Sorry for the noise and many thanks for the work!