risky to auto-walrus into while statements

Question

eriknw opened this issue 2 years ago · 3 comments

For example, changing

    i = 10
    while i > 0:
        i -= 1

to

    while (i := 10) > 0:
        i -= 1

is probably not desirable, since the latter never completes.

Answer 1 · 2022-10-11T18:50:23.000Z

thanks @eriknw , that's a very good point

not sure what (if anything?) can be done to detect when it's safe or not to rewrite while loops, so I'll remove it

Answer 2 · 2022-10-11T18:53:24.000Z

done in version 0.1.8

Answer 3 · 2022-10-11T19:05:23.000Z

Very fast, thanks 🎉 (also, neat library :) )