Text radio button not selected with text/no text as value in OpeningHoursFragment
Closed this issue · 8 comments
Description:
See issue description
Device info:
| App version | 12.1.4.0 |
| App version code | 1004 |
| Android build version | 2866453cc2 |
| Android release version | 8.1.0 |
| Android SDK version | 27 |
| Android build ID | lineage_tissot-userdebug 8.1.0 OPM7.181205.001 2866453cc2 |
| Device brand | Xiaomi |
| Device manufacturer | Xiaomi |
| Device name | tissot |
| Device model | Mi A1 |
| Device product name | lineage_tissot |
| Device hardware name | qcom |
| ABIs | [arm64-v8a, armeabi-v7a, armeabi] |
| ABIs (32bit) | [armeabi-v7a, armeabi] |
| ABIs (64bit) | [arm64-v8a] |
Extra info:
| OSM display name | scai |
This is the issue from simonpoole/beautified-JOSM-preset#139.
Can you give full details (best via the feedback menu item in the main menu so you don't need to type your device information in), including any prior contents of the fee field?
The previous value is empty. The bug occurs with a brand new element after selecting the amenity=parking preset. The bug also occurs if the fee tag has value yes or no.
What is displayed when you click two times in the text field? You should be getting a drop down with no, yes and potentially some extra values. And: are you using a custom preset?
Maybe it becomes clearer with this video:
As you can see the save button is disabled when text has been selected from the radio button. It doesn't matter which current value the fee tag has (a value containing valid opening hours behaves the same).
In the details widget there is a working drop down menu.
I don't use custom presets and never have.
Maybe it becomes clearer with this video:
Not really :-/.
As to how it should work:
Note the "Save" button will only activate if you've changed something.
To be clear I'm not disputing that there might be something wrong, I'm just trying to tickle out exactly what and why specifically your device is having the issue.
Oh. There has been a misunderstanding on my part. I didn't recognize the gray bar on top as an input field since it differs from the other UI in vespucci. Upon tapping on the gray bar a drop down menu appears.
Sorry, PEBCAK. You can close the issue.
I think the misunderstanding might be avoided by renaming "Text values" to "Text mode"?
The OpeningHoursFragment is actually a separate project and there are a couple of small styling differences (which probably should fixed).
The cause of this misunderstanding is probably the missing dialog title. All other radio button dialogs do have a large title whereas this one doesn't. I think I misinterpreted the "Fee" from the gray bar as dialog title and expected some other input field to appear. Adding a proper dialog title will make the input field more obvious.
@simonpoole As this user interface design is obviously misleading not only one user IMHO it makes sense to change it. I've the impression already 2 out of these 4 changes shall be sufficient - whichever are technically most easy to implement.
- Adding a dialog title above the 3rd party component as @scaidermern suggested. This shall look like for other vespucci dialogs like e.g. surface.
- Initially (i.e. if key has no value yet) do not show the name of the key (this appears like a dialog title) but empty the text field or set a text like "enter text here"?
- Add a lable before the text field, e.g. "Value: "
- Changing the sequence so that first, the radio buttons and then the text field appears